fengjun/setup-java
1
0
Fork 0
mirror of https://gitea.com/actions/setup-java.git synced 2026-07-11 19:41:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

Address cache.ts review feedback

Browse Source 
- saveAdditionalCache: handle @actions/cache ValidationError (thrown when the
  cache paths do not resolve, e.g. the wrapper distribution was never
  downloaded) by skipping instead of failing the post step. Add a test.
- Point the Gradle wrapper cache comment at issue #269 (Gradle wrapper cache
  churn) instead of the Maven-specific #1095.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
Bruno Borges
2026-07-09 21:21:56 -04:00
parent 90f45856e1
commit ec868c0274
4 changed files with 54 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
dist/cleanup/index.js vendored
View File

@@ -99700,7 +99700,7 @@ const supportedPackageManager = [
// The Gradle wrapper distribution only depends on the wrapper properties,
// which change very rarely, so it is cached separately from the Gradle
// caches. This keeps it available across the frequent *.gradle* changes
// that rotate the main cache key. See issue #1095.
// that rotate the main cache key. See issue #269.
additionalCaches: [
{
name: 'gradle-wrapper',
@@ -99900,6 +99900,13 @@ async function saveAdditionalCache(packageManager, additionalCache) {
}
catch (error) {
const err = error;
if (err.name === ValidationError.name) {
// The cache paths did not resolve, e.g. the wrapper distribution was
// never downloaded because a system build tool was used or the download
// failed. Optional wrapper caches must not fail the post step, so skip.
core_debug(`${additionalCache.name} cache paths do not exist, not saving cache: ${err.message}`);
return;
}
if (err.name === ReserveCacheError.name) {
info(err.message);
}

9
dist/setup/index.js vendored
View File

@@ -130922,7 +130922,7 @@ const supportedPackageManager = [
// The Gradle wrapper distribution only depends on the wrapper properties,
// which change very rarely, so it is cached separately from the Gradle
// caches. This keeps it available across the frequent *.gradle* changes
// that rotate the main cache key. See issue #1095.
// that rotate the main cache key. See issue #269.
additionalCaches: [
{
name: 'gradle-wrapper',
@@ -131122,6 +131122,13 @@ async function saveAdditionalCache(packageManager, additionalCache) {
}
catch (error) {
const err = error;
if (err.name === cache.ValidationError.name) {
// The cache paths did not resolve, e.g. the wrapper distribution was
// never downloaded because a system build tool was used or the download
// failed. Optional wrapper caches must not fail the post step, so skip.
core.debug(`${additionalCache.name} cache paths do not exist, not saving cache: ${err.message}`);
return;
}
if (err.name === cache.ReserveCacheError.name) {
core.info(err.message);
}